CYF - London | Anna Fedyna | Module-Structuring-and-Testing-Data | Week 3 #91

annafedyna · 2024-11-06T00:13:42Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

I’d appreciate it if you could review whether my input checks are efficient, especially when checking if a value is a number in get-angle-type.test.js !

This reverts commit 1f482ea.

CE-0

I have left you some feedback.

CE-0 · 2024-11-06T19:36:09Z

Sprint-1/errors/4.js

+const hourClockTime12 = "20:53";
+const hourClockTime24 = "08:53";


Assessment of problem is correct, but there seem further issues with the original variable declarations. I suggest taking a closer at the values of the variables in relation to the variable names to find the issue.

Right, thank you, the variable names and values were mismatched.
It should be :
const hourClockTime24 = "20:53"; const hourClockTime12 = "08:53";

CE-0 · 2024-11-06T19:37:11Z

Sprint-1/exercises/count.js

@@ -4,3 +4,5 @@ count = count + 1;

 // Line 1 is a variable declaration, creating the count variable with an initial value of 0
 // Describe what line 3 is doing, in particular focus on what = is doing
+
+/* the = operator here is taking the result of the expression on the right and assigning it to variable count */


I feel it would help to provide slightly more explanation as to what's happening here.

Of course, I will add here a bit more detailed explanation about what's happening with the = operator in JavaScript. So, in line 3, the = operator is used to assign the value on the right-hand side to the variable on the left-hand side. We have count = count + 1 . First, the value of count (which is initially 0) is accessed. Then, 1 is added to it, resulting in 1.This value (1) is assigned back to the variable count. The = operator here doesn't mean "equal" . Instead, it acts as an assignment operator which updates the variable with the new value.

CE-0 · 2024-11-06T19:38:22Z

Sprint-1/exercises/decimal.js

@@ -7,3 +7,11 @@ const num = 56.5678;
 // Create a variable called roundedNum and assign to it an expression that evaluates to 57 ( num rounded to the nearest whole number )

 // Log your variables to the console to check your answers
+
+const wholeNumberPart = Math.floor(num);
+const decimalPart = num - Math.floor(num);


This does not give the expected result, as it has too many decimal places. Perhaps there is a way to limit them.

We can use toFixed() to limit decimal places

CE-0 · 2024-11-06T19:38:45Z

Sprint-1/exercises/decimal.js

+
+
+
+console.log(roundedNum);


You were asked to log all the variables, not just one.

Thank you for pointing out!

CE-0 · 2024-11-06T19:41:04Z

Sprint-1/exercises/paths.js

 // Create a variable to store the ext part of the variable
+const extPart = base.slice(base.lastIndexOf('.')+1)


Look at the diagram above and see if it matches up exactly with your solution.

Yes, after reviewing the diagram and running the code it matches, please let me know if solution not aligns correctly

Please take note of all the characters under the 'base' column

CE-0 · 2024-11-06T19:42:41Z

Sprint-1/exercises/random.js

+/*
+    (maximum - minimum + 1) = 100
+    Math.random() - generates a random floating-point number between (0, 1)
+    Math.floor() - rounds down to the nearest whole number


What is the necessity for rounding down rather than rounding up?

So that num is not bigger than 100

CE-0 · 2024-11-06T19:43:25Z

Sprint-1/exercises/random.js

@@ -7,3 +7,15 @@ const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;
 // Try breaking down the expression and using documentation to explain what it means
 // It will help to think about the order in which expressions are evaluated
 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+
+/*
+    (maximum - minimum + 1) = 100


What is the purpose behind the multiplication?

The purpose is to scale the random value

cjyuan · 2024-11-10T06:49:00Z

I suppose this PR is for sprint-3 (since it says week 3)?
However, the current branch was created from Sprint-2 branch, and not from main. As a result, it contain modified files in both Sprint-1 and Sprint=2. Can you try to rebase the current branch so that it is branched out from main?

Apparently, this is a common mistake. See if can fix the issue from the suggestions found on Slack:
https://codeyourfutur-yov6609.slack.com/archives/C07PVEVQG9X/p1731018581934559

annafedyna · 2024-11-13T22:36:01Z

I suppose this PR is for sprint-3 (since it says week 3)? However, the current branch was created from Sprint-2 branch, and not from main. As a result, it contain modified files in both Sprint-1 and Sprint=2. Can you try to rebase the current branch so that it is branched out from main?

Apparently, this is a common mistake. See if can fix the issue from the suggestions found on Slack: https://codeyourfutur-yov6609.slack.com/archives/C07PVEVQG9X/p1731018581934559

Thank you very much for pointing out ! I rebased two branches.

annafedyna added 2 commits October 27, 2024 20:00

fixed errors sp1

1f482ea

Revert "fixed errors sp1"

ea15966

This reverts commit 1f482ea.

annafedyna added the Needs Review Participant to add when requesting review label Nov 6, 2024

CE-0 suggested changes Nov 6, 2024

View reviewed changes

cjyuan added 👀 Review Git Changes requested to do with Git and removed Needs Review Participant to add when requesting review labels Nov 10, 2024

annafedyna force-pushed the sprint-3 branch from 6f25d19 to ea15966 Compare November 11, 2024 00:34

annafedyna added 2 commits November 13, 2024 22:21

revise sp3 done

ef6b49f

implement sp3 done

d0b4dc5

		const hourClockTime12 = "20:53";
		const hourClockTime24 = "08:53";

		// Create a variable to store the ext part of the variable
		const extPart = base.slice(base.lastIndexOf('.')+1)




		console.log(roundedNum);

Uh oh!

CYF - London | Anna Fedyna | Module-Structuring-and-Testing-Data | Week 3 #91

Are you sure you want to change the base?

CYF - London | Anna Fedyna | Module-Structuring-and-Testing-Data | Week 3 #91

Uh oh!

Conversation

annafedyna commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

CE-0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 10, 2024

Uh oh!

annafedyna commented Nov 13, 2024

Uh oh!

Uh oh!

annafedyna commented Nov 6, 2024 •

edited

Loading